-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Github: improve docs & spec for BETA #11212
Conversation
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #11212 +/- ##
=========================================
Coverage ? 89.54%
=========================================
Files ? 3
Lines ? 555
Branches ? 0
=========================================
Hits ? 497
Misses ? 58
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/github-source
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/github-source |
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes based on conversation
airbyte-integrations/connectors/source-github/source_github/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-github/source_github/spec.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
/test connector=connectors/source-github
|
/test connector=connectors/source-github
|
/publish connector=connectors/source-github |
1 similar comment
/publish connector=connectors/source-github |
/publish connector=connectors/source-github
|
/publish connector=connectors/source-github
|
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
Refine and improve docs & spec for Beta
How
Full refresh
toIncremental
sectionauthSpecification
-> to newadvanced_auth
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here